This is the talk page for discussing improvements to the Module:Arguments page.
- Please sign and date your posts by typing four tildes (
~~~~). - Put new text under old text. Click here to start a new topic.
- If you're new to the wiki, please take a look at the talk page help.
- Be polite
- Assume good faith
- Be welcoming
Updating[]
Just a note for future reference: the most recent version of this module (at the time of writing) breaks because Wikia doesn't have frame:getTitle(docs). As far as I can tell, that's the only thing preventing us from updating.
DarthKitty (talk) 19:59, September 11, 2015 (UTC)
- Yes, there is a pull request for this in github(https://github.com/Wikia/app/pull/7495). However, it doesn't seem like a priority. If that's the only problem then you can probably pull it in using "frame:preprocess("Arguments"). The original Module:Arguments did that such a problem, see (line 88):
local title = mw.getCurrentFrame():preprocess("{{PAGENAME}}"):gsub('/sandbox$', '')
-- local title = parent:getTitle():gsub('/sandbox$', '')
Dessamator (talk) 22:14, September 11, 2015 (UTC)
- Oh, whoops! Turns out that was the problem after all—guess I panicked when I saw those Script errors. XD
- DarthKitty (talk) 00:00, September 12, 2015 (UTC)
32 tests failed[]
After updating the module and importing tests from Wikipedia, we have a new problem: 32 failures, all (apparently) caused by the missing frame:newChild method. Is there an easy workaround for this one, too?
ETA: doesn't look like there's a PR for frame:newChild, either. (I'm < 100% familiar with GitHub though, so maybe I missed something?)
DarthKitty (talk) 00:18, September 12, 2015 (UTC)
- Sure. If you look at the pseudo-frame function in Module:Devmodule you'll note that it does something very similar to frame:newchild. Basically all frame.newchild does is create a copy of the frame functions, and add a table of parameters along with the title. Currently pseudo-frame doesn't replace the title, because I didn't need it for devmodule.
- As far as I can tell there is no PR for frame:newChild. We could always ask if CQM is willing to make one, since CQM is a VolDev.
- Dessamator (talk) 10:23, September 12, 2015 (UTC)
- I've created a pseudo frame:NewChild in Module:Utility. This has reduced the number of errors down to 4. I'm not exactly sure if the errors left are due to a bug in my code related to newchild or something else related to Module:Arguments and/or wikia itself.Dessamator (talk) 14:14, October 6, 2015 (UTC)